You are not logged in.

Read the FAQ and Knowledge Base before posting.
WiFi not emulated and not supported!!
We won't make a 3DS/2DS emulator.



#1 2018-06-25 16:28:56

retr0s4ge
Member
Registered: 2018-06-25
Posts: 4

Desmume 0.9.12 with working WiFi

Hi,

I created a separate branch in a proper fork of desmume to test WiFi fixes from Desmume-Reloaded by Jackobo Le Chocobo. I applied the relevant fixes to snapshot of master branch taken at 22/06/2018.
Please review the branch with working WiFi here:
https://github.com/retr0s4ge/desmume/tr … _test_WiFi

and the compiled (x64) windows executable at:
https://ci.appveyor.com/project/retr0s4 … /artifacts

All credit for the 0.9.12 WiFi fix goes to Jackobo Le Chocobo, and for original code to Luigi_/StapleButter

I originally submitted a pull request for the changes, but closed it after I saw the official auto builder immediately applied it. Closing the pull request didn't remove the build, sorry about that.


[edit]
After testing for some time, I merged the changes in master20180622_test_WiFi to master branch, and rebased on current TASVideos/desmume master branch (bd63ff1 Tree).
https://github.com/retr0s4ge/desmume/tree/master

Compiled (x64) windows executable is at:
https://ci.appveyor.com/project/retr0s4 … /artifacts

Instructions for setting up WiFi and connecting to AltWFC network
https://github.com/retr0s4ge/desmume/wi … FC-network

Last edited by retr0s4ge (2018-06-29 17:00:26)

Offline

#2 2018-06-26 06:25:16

zeromus
Radical Ninja
Registered: 2009-01-05
Posts: 4,762

Re: Desmume 0.9.12 with working WiFi

I changed the buildbot to only build the master branch

Offline

#3 2018-06-29 13:13:21

retr0s4ge
Member
Registered: 2018-06-25
Posts: 4

Re: Desmume 0.9.12 with working WiFi

I re-based my master branch on current tree (bd63ff1) and submitted pull request.
https://github.com/TASVideos/desmume/pull/150

Last edited by retr0s4ge (2018-06-29 13:28:29)

Offline

#4 2018-06-29 17:09:50

zeromus
Radical Ninja
Registered: 2009-01-05
Posts: 4,762

Re: Desmume 0.9.12 with working WiFi

so whats your story? do you have deeper knowledge of this subject than you new github account would suggest? are you planning to continue development on it? are you just trying to be helpful and keep jackobo's commits alive since he's deleted his repository, so that once this is done you're gonna move on? I don't mind hosting jackobo's branch in a branch of ours, but if nobody's going to stick around and support it, I don't want it in master

Offline

#5 2018-06-30 01:05:50

retr0s4ge
Member
Registered: 2018-06-25
Posts: 4

Re: Desmume 0.9.12 with working WiFi

Hi, Thanks for replying.
I am new to GitHub, and this is my first time trying to contribute to an open source project.

As to why I am doing this, I wanted an up to date build with working WiFi to use myself. I found Jackobo's post here but his repository was gone. Thankfully though, someone else forked it before that. https://github.com/slawekwaga/DeSmuME-Reloaded
To prevent that work from being out of date after some time (especially that it is functioning very well), this should be merged upstream.

Jackobo didn't create an online fork of demume due to some conflicts with desmume developers, so I got the date Jackobo locally cloned the master branch from his post in this forum, cloned the desmume master branch at that date, and generated diff between his fork and that to get his commits. I forked desmume and applied the commits to a separate branch, fixed some missing includes and tested that build for a while. Which leaves us here...

As explained above, I have no relation with the development of the changes related to fixing WiFi and I am not familiar with the inner workings of WiFi on the NDS and thus the logic behind the code in wifi.cpp and wifi.h. Apart from that, the rest of the changes are fairly easy to read through and maintain.

So to answer your question, I am not planning to develop WiFi functionality any further than current state (Only infrastructure mode working correctly), but I can work my way around bugs that might be introduced by future commits and maintain it for the foreseeable future.

Some arguments when evaluating whether or not to merge to master:
1- Despite the large number of changed lines, they are mostly localized in 2 files wifi.cpp, wifi.h which aren't useful in their current state (before merge) anyway.

2- Changes to other files are minor such as adding command line options, include statements and logging function. These should be easy to maintain.
    If you want, we can discuss each change apart from those to wifi.cpp and wifi.h on the pull request page.

3- You can always omit "--enable-wifi" from ./configure for Linux build, and unset EXPERIMENTAL_WIFI_COMM in desmume.props for windows and builds will be back to current situation.

Offline

#6 2018-06-30 05:14:07

zeromus
Radical Ninja
Registered: 2009-01-05
Posts: 4,762

Re: Desmume 0.9.12 with working WiFi

I merged it and gave you commit permissions. Feel free to push future wifi work directly. If you want to do anything else, find us on IRC first

Offline

#7 2018-06-30 12:07:23

retr0s4ge
Member
Registered: 2018-06-25
Posts: 4

Re: Desmume 0.9.12 with working WiFi

Thanks, looking forward to contribute.

Offline

Board footer

Powered by FluxBB