--load-type and --cflash-path

PypeBros · 2017-02-28 21:15:55

Hello. I just realised that trying to use a dldi-function without --load-type=1 would end up in desmume crashing (version 0.9.11, ubuntu 16.04) because there would be no ROM image to patch. I thought it could be helpful to automate the setting of load_type to 1 as soon as a --cflash-* command is found on the list of arguments.

Good job on the emulator, btw.

zeromus · 2017-02-28 21:24:15

the whole internal distinctions between load types is garbage and will be fixed in the future. I'm surprised this crashes (I would expect desmume to skip the patch and your rom to just malfunction) and I dont know why it does, but it won't after the load types are fixed so that patches can apply in either scenario.

PypeBros · 2017-02-28 21:31:47

As far as I've been able to see, tryPatch ended up being called, with a NULL pointer instead of romdata.

zeromus · 2017-02-28 22:32:16

oh well, since you took the time to report it, and gave me a hint, I spent the 2 seconds it took to fix it. fix it from crashing, anyway. now it will just malfunction as designed

PypeBros · 2017-02-28 22:42:04

sounds fair. If I got bored of adding one more word on the command line, I'll just find a workaround on my own copy ;-)

Live long and prosper.

#1 2017-02-28 21:15:55

--load-type and --cflash-path

#2 2017-02-28 21:24:15

Re: --load-type and --cflash-path

#3 2017-02-28 21:31:47

Re: --load-type and --cflash-path

#4 2017-02-28 22:32:16

Re: --load-type and --cflash-path

#5 2017-02-28 22:42:04

Re: --load-type and --cflash-path

Board footer